Changed the shape of speaker icons in the timeline grid from rounded rectangle to circles #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectangles to circles
takahirom
reviewed
Aug 11, 2024
| @@ -240,7 +241,7 @@ private fun SpeakerIcon( | |||
| contentDescription = stringResource(SessionsRes.string.content_description_user_icon), | |||
| modifier = modifier | |||
| .size(TimetableGridItemSizes.speakerHeight) | |||
| .clip(RoundedCornerShape(8.dp)) | |||
| .clip(CircleShape) | |||
| .border( | |||
| BorderStroke(1.dp, MaterialTheme.colorScheme.outline), | |||
| RoundedCornerShape(8.dp), | |||
There was a problem hiding this comment.
Thanks! Could we change this as well to fix the border?
There was a problem hiding this comment.
Sorry. I missed this point. I will fix this point.
There was a problem hiding this comment.
I fixed this point.
![TimetableScreenTest[TimetableScreen - when server is operational - click timetable ui type change - it should change timetable ui type]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/%23224/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20timetable%20ui%20type%20change%20-%20it%20should%20change%20timetable%20ui%20type%5D_compare.png){kind=link}
takahirom
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)